Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tup-697 followup - rename templates #440

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 8, 2024

Overview

Proposal for better template names in user_news a.k.a. "User Updates" app.

Related

Changes

  • renamed several templates

Testing

  1. Explore templates directory and review proposed template names.
  2. Change news/user-updates/ page to 2-col layout with heading and "Full User News List" plugin.
  3. Verify "Full User News List" plugin lists all user updates.
  4. Open one of the user updates (that does not have an "Update" tag).
  5. Verify breadcrumbs are accurate and work.
  6. Verify page content is accurate and styled like prod.
  7. Open one of the user updates (that does have an "Update" tag).
  8. Verify updates to the page/news/update are shown.
  9. Open home page, and find "User News List" plugin instance.
  10. Verify "User News List" plugin instance lists some (not all) user updates.

UI

user.updates.list.-.full.mov
user.updates.list.-.short.mov
Home List Read
home page list page read page

Copy link
Contributor

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wesleyboar wesleyboar merged commit bede7fc into main Mar 8, 2024
1 check passed
@wesleyboar wesleyboar deleted the refactor/tup-697-followup-rename-proposal branch March 8, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants