Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[156] Map FOLIO chronology field to chron #157

Merged
merged 1 commit into from
Nov 9, 2021
Merged

[156] Map FOLIO chronology field to chron #157

merged 1 commit into from
Nov 9, 2021

Conversation

jsavell
Copy link
Member

@jsavell jsavell commented Nov 9, 2021

Resolves #156

The GIFM Service expects a multi-item holding to have volume/issue details for each item in a Catalog Service HoldingsRecord, either in the 'enumeration' field or 'chron' field, depending on the type of record.

This PR populates the 'chron' field for FOLIO integration from the source 'chronology' field.

'enumeration' was previously added.

@jsavell jsavell requested review from jeremythuff, kaladay and a user November 9, 2021 14:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1440026876

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 62.976%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/src/main/java/edu/tamu/catalog/service/FolioCatalogService.java 0 1 0.0%
Totals Coverage Status
Change from base Build 1338626282: -0.05%
Covered Lines: 728
Relevant Lines: 1156

💛 - Coveralls

@jsavell jsavell merged commit 5e19c0d into master Nov 9, 2021
@jsavell jsavell deleted the folio-chron branch November 9, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for FOLIO chronology field
3 participants