Sprint9 staging #177
Merged
Sprint9 staging #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han the version in the service pom for catalog service.
[169] Weaver dependency version in the parent pom is different than the version in the service pom for catalog service.
Some of the responses require more work, such as servicesPoint.json, and are skipped.
Update FOLIO mock responses.
The existing logic uses the InstanceId when instead it should use the ItemId. Switch to the ItemId to ensure each item works.
[167] Added discoveryDisplayName in Loan Response
Issue 194: Multiple items from the same bib record checked out.
…mConfig Hard coded prod urls removed from catalog config
kaladay
requested review from
jcreel,
jeremythuff,
a user,
rmathew1011 and
rladdusaw
Pull Request Test Coverage Report for Build 1797201446
💛 - Coveralls |
upgrade weaver to 2.1.1-RC1
ghost
reviewed
Feb 7, 2022
| for (JsonNode partialLoan : instanceIdToPartialLoan.values()) { | ||
| String loanId = getText(partialLoan, "/id"); | ||
| for (String loanId : itemIdToLoanId.values()) { | ||
| JsonNode partialLoan = loanIdToPartialLoan.get(loanId); |
There was a problem hiding this comment.
This map lookups make this a less performant change. May be negligible as is the changing pointers in the map.
jcreel
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.