Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch cached Redis manifest regression #127

Merged
2 commits merged into from
Dec 19, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2022

Description

RedisManifest final class member creation is no longer supported to be serialized with org.springframework.data.mapping.model.InstantiationAwarePropertyAccessor. Making the property not final and adding a setter resolves the issue.

Fixes #126

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Generated manifest, cached, and fetch cached manifest by making multiple requests to https://api-dev.library.tamu.edu/iiif-service/fedora/collection/london-maps-2

@ghost ghost linked an issue Dec 19, 2022 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 82.644% when pulling a91b1df on 126-redis-manifest-regression into 218fa0f on main.

@ghost ghost requested review from jcreel and kaladay December 19, 2022 18:30
@ghost ghost merged commit 1420ae3 into main Dec 19, 2022
@ghost ghost deleted the 126-redis-manifest-regression branch December 19, 2022 18:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to retrieve cached manifests
3 participants