Write feedback set and update tests for both Ideas and Feature Proposals

TAMULib · Aug 15, 2018 · ae81b1c · ae81b1c
1 parent 717ee12
commit ae81b1c
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 7 deletions.
diff --git a/src/test/java/edu/tamu/app/model/FeatureProposalTest.java b/src/test/java/edu/tamu/app/model/FeatureProposalTest.java
@@ -31,13 +31,15 @@ public class FeatureProposalTest {
 
     private static final String TEST_FEATURE_PROPOSAL_TITLE = "Feature Proposal Title";
     private static final String TEST_FEATURE_PROPOSAL_DESCRIPTION = "Test Feature Proposal Description";
+    private static final String TEST_FEATURE_PROPOSAL_FEEDBACK = "Feature Proposal Feedback";
 
     private static final String TEST_SERVICE_NAME = "Test Service Name";
     private static final String TEST_SERVICE_URL = "https://library.tamu.edu";
     private static final String TEST_SERVICE_DESCRIPTION = "Test Service Description";
 
     private static final String TEST_ALTERNATIVE_FEATURE_PROPOSAL_TITLE = "Alternative Feature Proposal Title";
     private static final String TEST_ALTERNATIVE_FEATURE_PROPOSAL_DESCRIPTION = "Alternative Feature Proposal Description";
+    private static final String TEST_ALTERNATIVE_FEATURE_PROPOSAL_FEEDBACK = "Alternative Feature Proposal Feedback";
 
     private static final String TEST_ALTERNATIVE_SERVICE_NAME = "Different Service Name";
 
@@ -197,6 +199,17 @@ public void testUpdateDescription() throws UserNotFoundException {
         assertEquals("FeatureProposal body not updated", TEST_ALTERNATIVE_FEATURE_PROPOSAL_DESCRIPTION, featureProposal.getDescription());
     }
 
+    @Test
+    public void testUpdateFeedback() throws UserNotFoundException {
+        FeatureProposal featureProposal = featureProposalRepo.create(testFeatureProposal, TEST_CREDENTIALS);
+        featureProposal.setFeedback(TEST_FEATURE_PROPOSAL_FEEDBACK);
+        featureProposal = featureProposalRepo.save(featureProposal);
+        assertEquals("FeatureProposal feedback not set", TEST_FEATURE_PROPOSAL_FEEDBACK, featureProposal.getFeedback());
+        featureProposal.setFeedback(TEST_ALTERNATIVE_FEATURE_PROPOSAL_FEEDBACK);
+        featureProposal = featureProposalRepo.save(featureProposal);
+        assertEquals("FeatureProposal feedback not updated", TEST_ALTERNATIVE_FEATURE_PROPOSAL_FEEDBACK, featureProposal.getFeedback());
+    }
+
     @Test
     public void testTimestampSetOnCreate() throws UserNotFoundException {
         FeatureProposal FeatureProposal = featureProposalRepo.create(testFeatureProposal, TEST_CREDENTIALS);

diff --git a/src/test/java/edu/tamu/app/model/IdeaTest.java b/src/test/java/edu/tamu/app/model/IdeaTest.java
@@ -29,14 +29,20 @@
 public class IdeaTest {
 
     private static final String TEST_IDEA_TITLE = "Idea Title";
+    private static final String TEST_IDEA_DESCRIPTION = "Test Idea Description";
+    private static final String TEST_IDEA_FEEDBACK = "Idea Feedback";
+    private static final String TEST_IDEA_EMAIL = "aggiejack@mailinator.com";
+
+    private static final String TEST_SERVICE_NAME = "Test Service Name";
     private static final String TEST_SERVICE_URL = "https://library.tamu.edu";
-    private static final String TEST_DESCRIPTION = "Test Service Description";
+    private static final String TEST_SERVICE_DESCRIPTION = "Test Service Description";
+
     private static final String TEST_ALTERNATIVE_IDEA_TITLE = "Alternative Idea Title";
-    private static final String TEST_SERVICE_NAME = "Test Service Name";
-    private static final String TEST_ALTERNATIVE_SERVICE_NAME = "Different Service Name";
-    private static final String TEST_IDEA_DESCRIPTION = "Test Idea Description";
+    private static final String TEST_ALTERNATIVE_IDEA_FEEDBACK = "Alternative Idea Feedback";
     private static final String TEST_ALTERNATIVE_IDEA_DESCRIPTION = "Alternative Idea Description";
-    private static final String TEST_IDEA_EMAIL = "aggiejack@mailinator.com";
+
+    private static final String TEST_ALTERNATIVE_SERVICE_NAME = "Different Service Name";
+
     private static final Boolean TEST_IS_AUTO = false;
     private static final Boolean TEST_IS_PUBLIC = true;
     private static final Boolean TEST_ON_SHORT_LIST = true;
@@ -78,8 +84,8 @@ public class IdeaTest {
     @Before
     public void setUp() throws UserNotFoundException {
         testUser = userRepo.create(TEST_CREDENTIALS.getUin(), TEST_CREDENTIALS.getEmail(), TEST_CREDENTIALS.getFirstName(), TEST_CREDENTIALS.getLastName(), Role.valueOf(TEST_CREDENTIALS.getRole()));
-        service1 = serviceRepo.create(new Service(TEST_SERVICE_NAME, TEST_SERVICE_STATUS, TEST_IS_AUTO, TEST_IS_PUBLIC, TEST_ON_SHORT_LIST, TEST_SERVICE_URL, TEST_DESCRIPTION));
-        service2 = serviceRepo.create(new Service(TEST_ALTERNATIVE_SERVICE_NAME, TEST_SERVICE_STATUS, TEST_IS_AUTO, TEST_IS_PUBLIC, TEST_ON_SHORT_LIST, TEST_SERVICE_URL, TEST_DESCRIPTION));
+        service1 = serviceRepo.create(new Service(TEST_SERVICE_NAME, TEST_SERVICE_STATUS, TEST_IS_AUTO, TEST_IS_PUBLIC, TEST_ON_SHORT_LIST, TEST_SERVICE_URL, TEST_SERVICE_DESCRIPTION));
+        service2 = serviceRepo.create(new Service(TEST_ALTERNATIVE_SERVICE_NAME, TEST_SERVICE_STATUS, TEST_IS_AUTO, TEST_IS_PUBLIC, TEST_ON_SHORT_LIST, TEST_SERVICE_URL, TEST_SERVICE_DESCRIPTION));
         testIdea = ideaRepo.create(new Idea(TEST_IDEA_TITLE, TEST_IDEA_DESCRIPTION, testUser, service1, TEST_IDEA_EMAIL), TEST_CREDENTIALS);
         testFeatureProposal = featureProposalRepo.create(new FeatureProposal(TEST_FEATURE_PROPOSAL_TITLE, TEST_FEATURE_PROPOSAL_DESCRIPTION, testUser, service1), TEST_CREDENTIALS);
     }
@@ -133,6 +139,17 @@ public void testUpdateDescription() throws UserNotFoundException {
         assertEquals("Idea body not updated", TEST_ALTERNATIVE_IDEA_DESCRIPTION, idea.getDescription());
     }
 
+    @Test
+    public void testUpdateFeedback() throws UserNotFoundException {
+        Idea idea = ideaRepo.create(testIdea, TEST_CREDENTIALS);
+        idea.setFeedback(TEST_IDEA_FEEDBACK);
+        idea = ideaRepo.save(idea);
+        assertEquals("Idea feedback not set", TEST_IDEA_FEEDBACK, idea.getFeedback());
+        idea.setFeedback(TEST_ALTERNATIVE_IDEA_FEEDBACK);
+        idea = ideaRepo.save(idea);
+        assertEquals("Idea feedback not updated", TEST_ALTERNATIVE_IDEA_FEEDBACK, idea.getFeedback());
+    }
+
     @Test
     public void testUpdateFeatureProposal() throws UserNotFoundException {
         Idea idea = ideaRepo.create(testIdea, TEST_CREDENTIALS);