Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offset management table margin bottom for service details view #108

Merged
1 commit merged into from
Aug 10, 2018
Merged

offset management table margin bottom for service details view #108

1 commit merged into from
Aug 10, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 9, 2018

No description provided.

@ghost ghost requested review from rladdusaw and kaladay August 9, 2018 19:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 115

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 16.239%
Files with Coverage Reduction New Missed Lines %
app/app.js 12 20.0%
Totals Coverage Status
Change from base Build 103: -0.9%
Covered Lines: 215
Relevant Lines: 1198
💛 - Coveralls

@ghost
Copy link
Author

ghost commented Aug 9, 2018

I don't understand how this pull request reduced test coverage.

kaladay
kaladay approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@kaladay kaladay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an acceptable solution.

@ghost ghost merged commit 45065eb into sprint6-staging Aug 10, 2018
@jcreel jcreel deleted the sprint6-d01209-extra-space branch August 27, 2018 21:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rladdusaw rladdusaw Awaiting requested review from rladdusaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coveralls @kaladay @wwelling