Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller refactor and staging service refactor #139

Merged
29 commits merged into from
Aug 17, 2018
Merged

controller refactor and staging service refactor #139

29 commits merged into from
Aug 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2018

No description provided.

rladdusaw and others added 27 commits August 15, 2018 16:54
@rladdusaw
Refactored service detail controller
ebd62e9
@kaladay
Rewrite tests to use a single beforeEach()
dfa7eb9 
By wrapping the contents of beforeEach() in a function, only a single beforeEach() needs to be defined per test file.
@kaladay
Implement/Update Service Detail Controller tests
8a6a8ca
@kaladay
Refactor mock repos fetchByAll() and findByAll() to use angular.copy()
72280ad 
Always make a copy of the object from the repo array to avoid passing the original object.
Use 'found' as the variable name to make the syntax more consistent and easier to copy.
@rladdusaw
Created new controllers and assigned them to views
eaae98c
@rladdusaw
Merge branch 'sprint6-controller-refactor' of https://github.com/TAMU…
3db143c 
…Lib/LibraryServiceStatusSystemUI into sprint6-controller-refactor
@rladdusaw
Finished refactoring
3c45b65
@kaladay
ServiceDetailController getServiceWebsite() should check link object …
d907a8a 
…before acting on it
@kaladay
Implement AbstractIdeaController test
e7f2098 
Some of the functions are omitted with the intent to be completed at a later date.
@kaladay
use 'id' as parameter in NoteRepo.fetchById repo mock
a80e809
@kaladay
pass empty object instead of $routeParams when injecting service deta…
0aecafc 
…il controller test
@kaladay
Implement basic tests for all controllers and add missing controllers.
16cdb77 
The mockUserService was updated to make thinks work for the controller tests and no effort was made to correctly implement it.
That work is reserved for when I get to refactoring, cleaning up, or otherwise improving the mocks.
@rladdusaw
Updated weaver table parameter
c0c55b3
@rladdusaw
Merge branch 'sprint6-controller-refactor' of https://github.com/TAMU…
626c1fd 
…Lib/LibraryServiceStatusSystemUI into sprint6-controller-refactor
@kaladay
Remove model tests that belong in weaver-ui-core
a2e8c88
@wwelling
removed unused method and ng-init call
489051a
@kaladay
use angulary.copy() should be angular.copy()
62bacaa
@wwelling
refactored project model using build paging of table factory
aee1f6a
@kaladay
improve tests coverage on abstract schedule controller
a4ae490
@wwelling
Merge branch 'sprint6-controller-refactor' of github.com:TAMULib/Libr…
a085716 
…aryServiceStatusSystemUI into sprint6-staging-service-refactor
@wwelling
minor regression fix
ca26aa7
@wwelling
use name for pager items
e45129c
@wwelling
cleanup and simplify table factor build paging
3b90c4a
@wwelling
major cleanup and simplification
8d157bf
@wwelling
removed injected timeout not used
c9af449
@wwelling
(wip) resolved table cross talk, page filter regression
83f4384
@wwelling
resolved service relation filter regression
83b9241
@ghost ghost requested review from rladdusaw and kaladay August 17, 2018 12:46
@coveralls
Copy link

coveralls commented Aug 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 305

  • 35 of 115 (30.43%) changed or added relevant lines in 18 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+11.9%) to 30.993%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/serviceDetailFeatureProposalManagementController.js 3 4 75.0%
app/controllers/featureProposalController.js 1 2 50.0%
app/controllers/ideaController.js 0 1 0.0%
app/controllers/serviceController.js 3 4 75.0%
app/controllers/notificationController.js 0 1 0.0%
app/controllers/noteController.js 0 1 0.0%
app/controllers/abstractIdeaController.js 0 2 0.0%
app/controllers/serviceDetailController.js 2 4 50.0%
app/directives/weaverTableDirective.js 0 5 0.0%
app/model/service.js 1 12 8.33%
Files with Coverage Reduction New Missed Lines %
app/directives/weaverTableDirective.js 1 1.22%
app/controllers/noteController.js 1 18.64%
app/model/service.js 1 2.78%
app/controllers/featureProposalController.js 1 32.05%
Totals Coverage Status
Change from base Build 266: 11.9%
Covered Lines: 409
Relevant Lines: 1159
💛 - Coveralls

rladdusaw
rladdusaw approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@rladdusaw rladdusaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to move to QA

@ghost ghost merged commit 4654f9f into sprint6-staging Aug 17, 2018
@jcreel jcreel deleted the sprint6-staging-service-refactor branch August 27, 2018 16:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coveralls @rladdusaw @kaladay @wwelling