Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deep link feature/issue request for given service #145

Merged
4 commits merged into from
Aug 22, 2018
Merged

deep link feature/issue request for given service #145

4 commits merged into from
Aug 22, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 22, 2018

No description provided.

@ghost ghost requested review from rladdusaw and kaladay August 22, 2018 13:41
@ghost
Copy link
Author

ghost commented Aug 22, 2018

Feature demonstrated and approved by product owner.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 340

  • 4 of 11 (36.36%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 30.8%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/detail/service/serviceDetailFeatureProposalListController.js 0 1 0.0%
app/controllers/requestController.js 4 10 40.0%
Files with Coverage Reduction New Missed Lines %
app/controllers/detail/service/serviceDetailFeatureProposalListController.js 1 26.92%
Totals Coverage Status
Change from base Build 335: -0.2%
Covered Lines: 411
Relevant Lines: 1172
💛 - Coveralls

@ghost ghost merged commit a0fe04d into sprint6-staging Aug 22, 2018
@jcreel jcreel deleted the sprint6-staging-deep-link-requests branch August 27, 2018 16:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rladdusaw rladdusaw Awaiting requested review from rladdusaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coveralls @kaladay @wwelling