Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv authority #205

Closed
wants to merge 6 commits into from
Closed

csv authority #205

wants to merge 6 commits into from

Conversation

jcreel
Copy link
Member

@jcreel jcreel commented Sep 4, 2018

No description provided.

@coveralls
Copy link

coveralls commented Sep 4, 2018

Coverage Status

Coverage increased (+0.6%) to 27.221% when pulling 89b2355 on csv-authority into d3ba413 on master.

@ghost ghost changed the title Csv authority csv authority Sep 5, 2018
@jcreel jcreel mentioned this pull request Sep 5, 2018
Copy link
Member

@jeremythuff jeremythuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will info logging impact performance? Ought these be debug logs?

@ghost
Copy link

ghost commented Sep 5, 2018

The performance hit is insignificant for the most part. But irrelevant at this time. The desire is to get all the logging into master to test in prod to isolate the remaining bottlenecks. After that all the logging and timing is to be removed.

@ghost ghost closed this Sep 6, 2018
@ghost ghost deleted the csv-authority branch September 6, 2018 15:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants