Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timing #206

Closed
wants to merge 3 commits into from
Closed

timing #206

wants to merge 3 commits into from

Conversation

jcreel
Copy link
Member

@jcreel jcreel commented Sep 4, 2018 •
edited by ghost

Included in PR #205

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 27.108% when pulling e4af8ab on timing into d3ba413 on master.

@ghost ghost changed the title Timing timing Sep 5, 2018
jeremythuff
jeremythuff requested changes Sep 5, 2018
View reviewed changes
Copy link
Member

@jeremythuff jeremythuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same observation as with #205, some of these .info logs seem like they will fire off often, maybe they should be debug level logs?

@ghost
Copy link

ghost commented Sep 5, 2018

They do fire very often and is intended.

@ghost ghost closed this Sep 6, 2018
@ghost ghost deleted the timing branch September 6, 2018 15:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremythuff jeremythuff jeremythuff requested changes

@jsavell jsavell Awaiting requested review from jsavell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcreel @coveralls @jeremythuff @wwelling