Skip to content

Commit

Permalink
Use StringUtils.isNotEmpty() over Optional.ofNullable()
Browse files Browse the repository at this point in the history
This also handles empty strings.
  • Loading branch information
kaladay committed Sep 18, 2020
1 parent 49a1ea2 commit 7059903
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/main/java/edu/tamu/app/ProjectInitialization.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import java.util.HashSet;
import java.util.Optional;

import org.apache.commons.lang3.StringUtils;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.CommandLineRunner;
import org.springframework.context.annotation.Profile;
Expand All @@ -30,8 +31,8 @@ public class ProjectInitialization implements CommandLineRunner {
@Override
public void run(String... args) throws Exception {
remoteProjectManagerRepo.findAll().forEach(versionManagementSoftware -> {
if (Optional.ofNullable(versionManagementSoftware.getUrl()).isPresent()) {
if (Optional.ofNullable(versionManagementSoftware.getToken()).isPresent()) {
if (StringUtils.isNotEmpty(versionManagementSoftware.getUrl())) {
if (StringUtils.isNotEmpty(versionManagementSoftware.getToken())) {
managementBeanRegistry.register(versionManagementSoftware);
}
}
Expand Down

0 comments on commit 7059903

Please sign in to comment.