Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprint7] [91] Replace manually created documentation with Spring Rest Docs #128

Merged
7 commits merged into from Oct 1, 2020

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Sep 30, 2020

Update tests, adding and enabling Restdocs.

resolves #91

…issing adocs.

The productsStatsApi.adoc and the remoteProjectStatsAPI.adoc are missing.
The RepoTest.java has everything that IntegrationTest.java needs and reproduces.
There may be extra data in the class tree, but this does not cause any observable problems.
…pproved.

Once this is reviewed and approved, this branch and commit should be rebuilt and replaced to point to master branch.
Relocate the cached controller API to the top as they are what is most likely desired.

Remove remoteProjectAPI.adoc and RemoteProjectControllerIntegrationTest.java..

Make sure the index.adoc has all of the appropriate files.

Fix incorrect path, `/status` clearly should instead be `/remote-project-manager`.

Remove the FIXME, this appears to now be working with the removal of RemoteProjectControllerIntegrationTest.java and/or remoteProjectAPI.adoc.

Filenames need to use `API` and not `Api`.
@kaladay kaladay requested review from a user and rladdusaw September 30, 2020 16:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 494

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 96.337%

Files with Coverage Reduction New Missed Lines %
src/main/java/edu/tamu/app/service/manager/VersionOneService.java 1 98.91%
src/main/java/edu/tamu/app/service/registry/ManagementBeanRegistry.java 1 92.86%
src/main/java/edu/tamu/app/cache/service/RemoteProjectsScheduledCacheService.java 2 90.91%
src/main/java/edu/tamu/app/cache/service/ActiveSprintsScheduledCacheService.java 6 84.31%
Totals Coverage Status
Change from base Build 482: -0.2%
Covered Lines: 1236
Relevant Lines: 1283

💛 - Coveralls

@ghost ghost merged commit b83ebc2 into sprint7-staging Oct 1, 2020
@ghost ghost deleted the sprint7-91-tests branch November 30, 2020 16:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants