Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missed configuration and defer to parent project for test dependency versions #159

Merged
3 commits merged into from
Aug 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2022

No description provided.

@coveralls
Copy link

coveralls commented Aug 8, 2022

Coverage Status

Coverage remained the same at 94.601% when pulling bc2f729 on wrapup into 279e17a on staging.

@ghost ghost requested a review from kaladay August 9, 2022 17:35
@ghost ghost marked this pull request as ready for review August 9, 2022 17:35
@ghost ghost changed the title some missed configuration on upgrade Update missed configuration and defer to parent project for test dependency versions Aug 9, 2022
@ghost ghost merged commit 0283499 into staging Aug 9, 2022
@ghost ghost deleted the wrapup branch August 9, 2022 17:36
ghost pushed a commit that referenced this pull request Aug 25, 2022
* ad pr and issue templates

* Update missed configuration and defer to parent project for test dependency versions (#159)

* some missed configuration on upgrade

* fix in dependencies

* allow-access dev default update

* Standardize the multiple forms of gitignore

* add contributing and deploying and update readme

* upgrade weaver

* normalize pom.xml with autoformat

* update dockerfile

* cleanup log files

* add deployment section to readme

* update build workflow

* Move bytebuddy into a profile.

Spring doesn't support the byte buddy version needed by tests.
Move bytebuddy into a special profile.
This byte buddy version is required for testing to avoid flaws or bugs in the byte buddy version.

* Update: Default port needs to be 9000.

* Use .gitignore based off of App Repos.

* Update readme and related files for consistency.

- Fix simple mistakes.
- Use long/full names in titles without acronyms.
- Leave most of the README.md design as-is for comparison against alternative methods.
- Fix license sentence.
- Fix line endings where needed.
- Use different documentation for cases where there is no `docker-compose` available (as in, no UI or App Repos).
- Some documents have the incorrect link styling, which doesn't work.
- Make readme and related files more consistent.

* Use project-specific name in docker deploy instructions.

* Make Dockerfile more consistent.

- Remove SOURCE_DIR when not needed.
- Always clean and clear apt cache to reduce docker disk usage.
- Make sure the SOURCE_DIR exists when not copying it wholesale.
- Remove any spurious new lines.

* This is a service repo not a UI repo.

Co-authored-by: Kevin Day <kday@library.tamu.edu>
Co-authored-by: Kevin Day <35114839+kaladay@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants