Sprint5 61 multiple remote projects #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaladay
approved these changes
May 4, 2020
kaladay
added a commit
that referenced
this pull request
Sep 10, 2020
This expands upon PR #97 further removing the basic authentication for VersionOne as well. With these changes, it makes sense to remove the settings and simplify the model design. This better allows for validation using the existing weaver validation functionality. The most notable downside of this particular implementation is the database changes. The URL is now a validated and required part of the ManagementService. The token is now a validated part of the ManagementService, but is not explicitly required via the DB. Both Github and VersionOne require token, so the default behavior is to require the token. The token remains encrypted. see: #70 see: #97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #61