Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint2 startup fixes #15

Merged
3 commits merged into from Jun 28, 2018
Merged

Sprint2 startup fixes #15

3 commits merged into from Jun 28, 2018

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Jun 19, 2018

This fixes problems that have prevented me from getting a functional development setup working.

I also had to remove 'coveralls' from Gruntfile.js.
That change is likely a separate issue and is omitted from this pull request.

This causing problems on case-sensitive OS's.
Use the file name with the expected case.
Grunt is somehow not installed correctly, causing setup and installation (npm install) to fail.
This changes the behavior to be identical to how library-webservices-status installs grunt.
@kaladay kaladay requested a review from rladdusaw June 19, 2018 13:41
This reverts commit 495e312.

Reason: duplicate of commit 63d3ada.
@coveralls
Copy link

coveralls commented Jun 19, 2018

Pull Request Test Coverage Report for Build 20

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.644%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/model/versionManagementSoftware.js 1 3 33.33%
Totals Coverage Status
Change from base Build 14: 0.0%
Covered Lines: 126
Relevant Lines: 239

💛 - Coveralls

@kaladay kaladay changed the base branch from sprint2 to sprint2-staging June 19, 2018 18:44
@ghost ghost merged commit 316f46e into sprint2-staging Jun 28, 2018
@ghost ghost deleted the sprint2-startup_fixes branch June 28, 2018 13:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants