Wrap the resource existence check to ensure it doesn't throw an exception on non-existence. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaladay
requested review from
jcreel,
jeremythuff,
a user,
rmathew1011 and
rladdusaw
Pull Request Test Coverage Report for Build 2185285810
💛 - Coveralls |
…tion on non-existence.
The URI is being passed to avoid needing to get the URI from the Resource. Getting the URI from the Resource would introduce another exception that needs to be handled.
kaladay
force-pushed
the
2.x-resource_exists_exception
branch
from
70bada5
to
84dd95a
Compare
ghost
approved these changes
Apr 18, 2022
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for WRO to compile on projects like Vireo.
This takes the approach of providing a work-around in Weaver rather than trying to delve into the WRO code, provide a fix, and possibly fork their project.