-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Build components with Node 16 or greater.
Add minimum requirement of Node 16 and npm 8.
Upgrade dependencies, where possible.
Some packages are not upgrade due to problems or potential problems.
Switch from `rxjs` to `rxjs-compat`, which is the new location for the old `rxjs` that we are using.
This allows for using the `^` character to get the latest bugfix version for the 6.x releases.
Replace tslint with eslint using `tslint-to-eslint-config` like this:
```
npx tslint-to-eslint-config --prettier --comments
```
This requires removing `angular-tslint-rules`.
Fix bug in `scripts/build-version.js` that prevents building.
The directory path `./dist/bundle` may not exist and needs to be created if it does not exist.
Running this on Node 18 is not easily supported.
An extra step of adding an environment variable might be needed, such as:
```
export NODE_OPTIONS=--openssl-legacy-provider
```
Switching to the new Angular (13+, 14+, etc..) would avoid this but this introduces more problems.
The `package.json` utilizes `overrides` for eslint due to webpack bringing in a version that causes problems:
```
Error: node_modules/@types/eslint/index.d.ts:451:42 - error TS2724: '"/home/runner/work/weaver-components/weaver-components/node_modules/@types/estree/index"' has no exported member named 'ChainExpression'. Did you mean 'ThisExpression'?
451 ChainExpression?: ((node: ESTree.ChainExpression & NodeParentExtension) => void) | undefined;
~~~~~~~~~~~~~~~
Error: node_modules/@types/eslint/index.d.ts:474:43 - error TS2694: Namespace '"/home/runner/work/weaver-components/weaver-components/node_modules/@types/estree/index"' has no exported member 'ImportExpression'.
474 ImportExpression?: ((node: ESTree.ImportExpression & NodeParentExtension) => void) | undefined;
~~~~~~~~~~~~~~~~
Error: Process completed with exit code 1.
```
Updated dependencies based on the results of:
```
npx npm-check-updates
```- Loading branch information
Showing
6 changed files
with
128 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| 👋 Hi! This file was autogenerated by tslint-to-eslint-config. | ||
| https://github.com/typescript-eslint/tslint-to-eslint-config | ||
| It represents the closest reasonable ESLint configuration to this | ||
| project's original TSLint configuration. | ||
| We recommend eventually switching this configuration to extend from | ||
| the recommended rulesets in typescript-eslint. | ||
| https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md | ||
| Happy linting! 💖 | ||
| */ | ||
| module.exports = { | ||
| "env": { | ||
| "browser": true, | ||
| "node": true | ||
| }, | ||
| "extends": [ | ||
| "prettier" | ||
| ], | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "project": "tsconfig.json", | ||
| "sourceType": "module" | ||
| }, | ||
| "plugins": [ | ||
| "eslint-plugin-import", | ||
| "@angular-eslint/eslint-plugin", | ||
| "@typescript-eslint", | ||
| "@typescript-eslint/tslint" | ||
| ], | ||
| "root": true, | ||
| "rules": { | ||
| "@angular-eslint/component-selector": [ | ||
| "error", | ||
| { | ||
| "type": "element", | ||
| "prefix": "tl", | ||
| "style": "kebab-case" | ||
| } | ||
| ], | ||
| "@angular-eslint/directive-selector": [ | ||
| "error", | ||
| { | ||
| "type": "attribute", | ||
| "prefix": "tl", | ||
| "style": "camelCase" | ||
| } | ||
| ], | ||
| "@typescript-eslint/member-ordering": "error", | ||
| "@typescript-eslint/tslint/config": [ | ||
| "error", | ||
| { | ||
| "rules": { | ||
| "comment-type": true | ||
| } | ||
| } | ||
| ], | ||
| "import/no-deprecated": "warn", | ||
| "import/no-extraneous-dependencies": [ | ||
| "error", | ||
| { | ||
| "devDependencies": false | ||
| } | ||
| ], | ||
| "import/order": "error" | ||
| } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,6 @@ | |
| "node_modules/codelyzer" | ||
| ], | ||
| "extends": [ | ||
| "angular-tslint-rules" | ||
| ], | ||
| "rules": { | ||
| "deprecation": { | ||
|
|
||