1.x sprint23 staging #402
Merged
1.x sprint23 staging #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaladay
commented
Nov 2, 2021
•
kaladay
commented
- The mobile menu slide out tray continues to allow links to be clicked on when closed. by @kaladay in Issue 389: The mobile menu slide out tray continues to allow links to be clicked on when closed. #405
- Verify that TAMU Library Components is showing icons in the mobile menu. by @kaladay in Issue 395: Verify that TAMU Library Components is showing icons in the mobile menu. #404
- Tl header top nav dropdown menu position by @rmathew1011 in 1.x sprint23 396 tl header top nav dropdown menu position #408
Add new command `build:npm-local` to build utilizing the local repository. This will re-install the wvr dependency using a local registry with the `--no-save` to ensure that the package.json is not updated in the process.
…e mobile menu. The issue is verified that the issue appears only in 1.x and not 2.x. Investigating why this is the case revealed that the icons aren't even in the repository. The 2.x prevents blacklisting the bootstrap icons assets in the `.gitignore` file but the 1.x does not. This issue is tagged as a spike, but fixing the issue immediately makes more sense given that it is just adding static files.
… be clicked on when closed.
Issue 389: The mobile menu slide out tray continues to allow links to be clicked on when closed.
Issue 395: Verify that TAMU Library Components is showing icons in the mobile menu.
…y the dd menu in the right position
…av-dropdown-menu-position 1.x sprint23 396 tl header top nav dropdown menu position
jeremythuff
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.