Build components with Node 16 or greater. #430
Merged
+128
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add minimum requirement of Node 16 and npm 8.
Upgrade dependencies, where possible.
Some packages are not upgrade due to problems or potential problems.
Switch from `rxjs` to `rxjs-compat`, which is the new location for the old `rxjs` that we are using.
This allows for using the `^` character to get the latest bugfix version for the 6.x releases.
Replace tslint with eslint using `tslint-to-eslint-config` like this:
```
npx tslint-to-eslint-config --prettier --comments
```
This requires removing `angular-tslint-rules`.
Fix bug in `scripts/build-version.js` that prevents building.
The directory path `./dist/bundle` may not exist and needs to be created if it does not exist.
Running this on Node 18 is not easily supported.
An extra step of adding an environment variable might be needed, such as:
```
export NODE_OPTIONS=--openssl-legacy-provider
```
Switching to the new Angular (13+, 14+, etc..) would avoid this but this introduces more problems.
The `package.json` utilizes `overrides` for eslint due to webpack bringing in a version that causes problems:
```
Error: node_modules/@types/eslint/index.d.ts:451:42 - error TS2724: '"/home/runner/work/weaver-components/weaver-components/node_modules/@types/estree/index"' has no exported member named 'ChainExpression'. Did you mean 'ThisExpression'?
451 ChainExpression?: ((node: ESTree.ChainExpression & NodeParentExtension) => void) | undefined;
~~~~~~~~~~~~~~~
Error: node_modules/@types/eslint/index.d.ts:474:43 - error TS2694: Namespace '"/home/runner/work/weaver-components/weaver-components/node_modules/@types/estree/index"' has no exported member 'ImportExpression'.
474 ImportExpression?: ((node: ESTree.ImportExpression & NodeParentExtension) => void) | undefined;
~~~~~~~~~~~~~~~~
Error: Process completed with exit code 1.
```
Updated dependencies based on the results of:
```
npx npm-check-updates
```
mumptastic
approved these changes
Aug 30, 2022
This was referenced Sep 1, 2022
|
This happened to solve this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add minimum requirement of Node 16 and npm 8.
Upgrade dependencies, where possible.
Some packages are not upgrade due to problems or potential problems.
Switch from
rxjstorxjs-compat, which is the new location for the oldrxjsthat we are using.This allows for using the
^character to get the latest bugfix version for the 6.x releases.Replace tslint with eslint using
tslint-to-eslint-configlike this:This requires removing
angular-tslint-rules.Fix bug in
scripts/build-version.jsthat prevents building.The directory path
./dist/bundlemay not exist and needs to be created if it does not exist.Running this on Node 18 is not easily supported.
An extra step of adding an environment variable might be needed, such as:
Switching to the new Angular (13+, 14+, etc..) would avoid this but this introduces more problems.
The
package.jsonutilizesoverridesfor eslint due to webpack bringing in a version that causes problems:Updated dependencies based on the results of:
resolves #429