Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make consistent with recent tech-debt changes. #440

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Make consistent with recent tech-debt changes. #440

merged 1 commit into from
Sep 26, 2022

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Sep 23, 2022

  • Apply the same .gitignore practices from the UI repos.
  • Use a build directory.
  • Utilize the npmrc for helping get cross-OS support for Docker.
  • Follow more recent Docker write-up practices.

resolves TAMULib/weaver-components#497

@kaladay kaladay linked an issue Sep 23, 2022 that may be closed by this pull request
Port Docker changes from recent Tech Debt work into wvr-components TAMULib/weaver-components#497
Closed
@kaladay kaladay merged commit 0cfad5e into staging Sep 26, 2022
@kaladay kaladay deleted the 497-docker_changes branch December 9, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumptastic mumptastic Awaiting requested review from mumptastic

@jcreel jcreel Awaiting requested review from jcreel

@jeremythuff jeremythuff Awaiting requested review from jeremythuff

@rmathew1011 rmathew1011 Awaiting requested review from rmathew1011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port Docker changes from recent Tech Debt work into wvr-components
1 participant
@kaladay