removed child component test

TAMULib · Oct 1, 2020 · 7b6ab6c · 7b6ab6c
1 parent 50f258e
commit 7b6ab6c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 32 deletions.
diff --git a/projects/wvr-elements/src/lib/core/component-registry.service.ts b/projects/wvr-elements/src/lib/core/component-registry.service.ts
@@ -28,6 +28,7 @@ export class ComponentRegistryService {
   }
 
   getComponentByElement(element: HTMLElement): WvrBaseComponent {
+
     const hasNativeId = element.hasAttribute('wvr-id');
     const htmlID = hasNativeId ? element.getAttribute('wvr-id') : element.getAttribute('id');
 

diff --git a/projects/wvr-elements/src/lib/wvr-tabs/wvr-tab/wvr-tab.component.spec.ts b/projects/wvr-elements/src/lib/wvr-tabs/wvr-tab/wvr-tab.component.spec.ts
diff --git a/projects/wvr-elements/src/lib/wvr-tabs/wvr-tab/wvr-tab.component.ts b/projects/wvr-elements/src/lib/wvr-tabs/wvr-tab/wvr-tab.component.ts
@@ -39,8 +39,12 @@ export class WvrTabComponent extends WvrBaseComponent implements AfterViewInit {
 
   ngAfterViewInit(): void {
     const tabsElements: HTMLElement = (this._eRef.nativeElement as HTMLElement).closest('wvr-tabs');
-    this.parent = this.componentRegistry.getComponentByElement(tabsElements) as WvrTabsComponent;
-    this.parent.addTab(this);
+    if (tabsElements) {
+      this.parent = this.componentRegistry.getComponentByElement(tabsElements) as WvrTabsComponent;
+      this.parent.addTab(this);
+    } else {
+      console.warn('The wvr-tab component must be contained within a wvr-tabs component.');
+    }
   }
 
   getTabContent(): SafeHtml {