Revert sass migration PR 457. #460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sprint22 staging sass migration
This reverts PR #457. Problems were found and further investigation needs to be performed before this is ready to be in a release.
rmathew1011
force-pushed
the
sprint22-staging
branch
from
7862fef
to
edd2d78
Compare
kaladay
pushed a commit
that referenced
this pull request
Nov 1, 2021
This is work by @rmathew1011 that was introduced in PR #457 and then temporarily reverted as seen in PR #460. Whatever is causing the problem that resulted in the need to revert the designated PR is not a problem when using the newly created local repository build strategy (using verdaccio). The switch to a package process (`npm run start:npm-local`, `npm run publish:npm-local`, and `npm run build:npm-local`) has allowed for a working build environment between weaver-components and tamu-library-components. As of this change, the `build:link` and `build:link-wvr` likely does not work consistently across environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #457.
Problems were found and further investigation needs to be performed before this is ready to be in a release.