-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfold Colored Nets #10
Conversation
If cross compiling the tool chain need to be passed to external dependencies explicitly
Pass CMAKE_TOOLCHAIN_FILE down to external projects
flex/bison needs to be discovered before external pacakges are build as they need it
@@ -12,6 +12,7 @@ namespace VerifyTAPN { | |||
|
|||
TimedArcPetriNet *TAPNXmlParser::parse(const std::string &filename) const { | |||
const std::string contents = VerifyTAPN::readFile(filename); | |||
std::cout << "empty? " << contents << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not perfect, but it does the job.
Why the Cmake file changes the compatibility for Mac from 10.8 to -mmacosx-version-min=11.2 This will not work on my OSX that people are still running? |
We should really make this a variable to that it can be set when configuring cmake. But to answer question, the version needs to match whatever SDK is available on the github runners. The seems to have same support cadance as Apple, being N-2, meaning the support latest release plus the two preceding releases (although Apples does not have an official policy this is what historicly has been the case). I updated the version to be 10.15 (2019) which is the oldest SDK on the github runner, however i'm not sure that it will have the desired effect,
By the way 10.8 is from 2009, but if we need to support this old devices for release we need to still build it manually on an old machine. For CI testing I think it's fine to use newer versions. |
Part of the color work at https://code.launchpad.net/~tapaal-contributor/tapaal/cpn-gui-dev/+merge/404184
(Check for updates TAPAAL-Developers/verifydtapn@unfoldColor...PeterHaahrTaankvist:unfolding_library)