Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfold Colored Nets #10

Merged
merged 25 commits into from
Nov 12, 2021
Merged

Unfold Colored Nets #10

merged 25 commits into from
Nov 12, 2021

Conversation

yrke
Copy link
Member

@yrke yrke commented Aug 5, 2021

@@ -12,6 +12,7 @@ namespace VerifyTAPN {

TimedArcPetriNet *TAPNXmlParser::parse(const std::string &filename) const {
const std::string contents = VerifyTAPN::readFile(filename);
std::cout << "empty? " << contents << std::endl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@petergjoel petergjoel self-requested a review November 9, 2021 14:06
Copy link
Member

@petergjoel petergjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not perfect, but it does the job.

@petergjoel petergjoel requested a review from srba November 9, 2021 14:07
@srba
Copy link
Member

srba commented Nov 9, 2021

Why the Cmake file changes the compatibility for Mac from 10.8 to

-mmacosx-version-min=11.2

This will not work on my OSX that people are still running?

@yrke
Copy link
Member Author

yrke commented Nov 10, 2021

Why the Cmake file changes the compatibility for Mac from 10.8 to -mmacosx-version-min=11.2

We should really make this a variable to that it can be set when configuring cmake.

But to answer question, the version needs to match whatever SDK is available on the github runners. The seems to have same support cadance as Apple, being N-2, meaning the support latest release plus the two preceding releases (although Apples does not have an official policy this is what historicly has been the case).

I updated the version to be 10.15 (2019) which is the oldest SDK on the github runner, however i'm not sure that it will have the desired effect,

  1. im not sure the value is passed down to dependens (or how this will affect build if its not passed down),
  2. it seems the version of GCC we use is compiled with 11.3 and it outputs warnings about this in the log, (I think it was 11.2 when i did the original port, therefore it was originally set to 11.2)

By the way 10.8 is from 2009, but if we need to support this old devices for release we need to still build it manually on an old machine. For CI testing I think it's fine to use newer versions.

@srba srba merged commit d7cddfd into TAPAAL:main Nov 12, 2021
@yrke yrke deleted the unfoldColor branch November 15, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants