Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash when right clicking genesis VDP viewer palette box #1449

Closed
zeromus opened this issue Jan 15, 2019 · 1 comment
Closed

crash when right clicking genesis VDP viewer palette box #1449

zeromus opened this issue Jan 15, 2019 · 1 comment
Assignees
@zeromus
Labels
Core: Genplus-gx Sega Genesis / Mega Drive core Repro: Affects 2.3/2.3.1/2.3.2 (2.3.3 has its own label) Repro: Fixed/added as of 2.3/2.3.1/2.3.2 (2.3.3 has its own label)

Comments

@zeromus
Copy link
Contributor

zeromus commented Jan 15, 2019 •
edited by YoshiRulz
Loading

Title.

[...]
System.NullReferenceException: Object reference not set to an instance of an object.
   at BizHawk.Client.EmuHawk.GenVDPViewer.DrawTiles()
   at System.Windows.Forms.Control.OnMouseClick(MouseEventArgs e)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
[...]

The method in question

edit: stacktrace and link to code --yoshi
@zeromus zeromus self-assigned this Jan 15, 2019
@Asnivor Asnivor added Bug (GoogleCode) Grandfathered label from GoogleCode. Use the other bug labels. Core: Genplus-gx Sega Genesis / Mega Drive core labels Jan 17, 2019
@YoshiRulz YoshiRulz added the Repro: Affects 2.3/2.3.1/2.3.2 (2.3.3 has its own label) label Mar 1, 2019
@alyosha-tas
Copy link
Contributor

Seems like DrawTiles() in bmpViewPal_MouseClick should be UpdateValues() instead, otherwise View is null.

@YoshiRulz YoshiRulz added Repro: Fixed/added as of 2.3/2.3.1/2.3.2 (2.3.3 has its own label) and removed Bug (GoogleCode) Grandfathered label from GoogleCode. Use the other bug labels. labels Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeromus zeromus

Labels
Core: Genplus-gx Sega Genesis / Mega Drive core Repro: Affects 2.3/2.3.1/2.3.2 (2.3.3 has its own label) Repro: Fixed/added as of 2.3/2.3.1/2.3.2 (2.3.3 has its own label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zeromus @Asnivor @YoshiRulz @alyosha-tas