Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gambatte] Upstream testrunner fails 13 tests for Bizhawk-Gambatte #2657

Closed
CasualPokePlayer opened this issue Mar 8, 2021 · 2 comments · Fixed by #2665
Closed

[Gambatte] Upstream testrunner fails 13 tests for Bizhawk-Gambatte #2657

CasualPokePlayer opened this issue Mar 8, 2021 · 2 comments · Fixed by #2665
Assignees
@TiKevin83
Labels
Core: Gambatte (Alt.) Game Boy / Color (GB/GBC) core Repro: Fixed/added in 2.6.2

Comments

@CasualPokePlayer
Copy link
Member

CasualPokePlayer commented Mar 8, 2021 •
edited
Loading

I've done some work to get Gambatte's testrunner to be compatible with Bizhawk's Gambatte, and in doing so have uncovered 13 failures from the test suite. All tests pass upstream, so something is wrong within Bizhawk's fork.

failures
@CasualPokePlayer CasualPokePlayer changed the title (Gambatte) - Testrunner fails 8 tests (Gambatte) - Testrunner fails 13 tests Mar 8, 2021
@YoshiRulz YoshiRulz added the Core: Gambatte (Alt.) Game Boy / Color (GB/GBC) core label Mar 8, 2021
@YoshiRulz
Copy link
Member

Do the test cases differ between gambatte and gambatte-speedrun? If so, which are you comparing our fork to?

@CasualPokePlayer
Copy link
Member Author

CasualPokePlayer commented Mar 8, 2021 •
edited
Loading

As in do the tests differ? No. The tests are identical.

If you mean the test results differ? Probably not. Gambatte-Speedrun (which should be considered upstream) passes all tests. Base Gambatte probably passes all the tests (the commit that made all the tests pass on Gambatte-Speedrun was just merging all changes base Gambatte made in 2019), but I haven't verified that myself.

edit: ran the tests on base Gambatte and all pass on there too.

@CasualPokePlayer CasualPokePlayer changed the title (Gambatte) - Testrunner fails 13 tests [Gambatte] - Testrunner fails 13 tests Mar 8, 2021
@CasualPokePlayer CasualPokePlayer changed the title [Gambatte] - Testrunner fails 13 tests [Gambatte] Testrunner fails 13 tests Mar 8, 2021
@CasualPokePlayer CasualPokePlayer changed the title [Gambatte] Testrunner fails 13 tests [Gambatte] Upstream testrunner fails 13 tests Mar 8, 2021
@CasualPokePlayer CasualPokePlayer changed the title [Gambatte] Upstream testrunner fails 13 tests [Gambatte] Upstream testrunner fails 13 tests for Bizhawk-Gambatte Mar 8, 2021
CasualPokePlayer added a commit to CasualPokePlayer/gambatte-speedrun that referenced this issue Mar 9, 2021
@CasualPokePlayer
add in missed code from 2019 base Gambatte merge, fixes TASEmulators/…
a3c908e 
…BizHawk#2657
@TiKevin83 TiKevin83 mentioned this issue Mar 15, 2021
Merged
@TiKevin83 TiKevin83 self-assigned this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TiKevin83 TiKevin83

Labels
Core: Gambatte (Alt.) Game Boy / Color (GB/GBC) core Repro: Fixed/added in 2.6.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gambatte-speedrun GBA modeswitch timing and testROM accuracy TiKevin83/BizHawk
3 participants
@YoshiRulz @TiKevin83 @CasualPokePlayer