Savestates (and branches in TAStudio) are 0-indexed

[Morilli]

Not sure whether it's just me or I am missing something, but I feel like it would make more sense if savestates and branches were 1-indexed instead of 0-indexed, aka the first savestate/branch is 1, the second 2, and so forth.

Main reasoning for me personally is that I like to make and load TAStudio branches via the savestate hotkeys (F1-F10 to load and Shift+F1-F10 to save), and I can either not save branch 0 comfortably, or I offset my hotkeys by 1 (aka F1 loads branch 0, F2 loads branch 1, etc.), which is also weird to keep in mind all the time.

Idk, maybe you're supposed to treat branch 0 as something special or something, but in my workflow at least it is just the first branch to me.

[YoshiRulz]

see also #2023

edit: I didn't understand this fully when triaging. Now that I do, I'm going to call it a bug because it's so user-hostile.
The savestate slots are drawn in the status bar and File > Save/Load State (but not File > Save Slot!) from 1, and the default hotkeys are from F1 (F1 = 1, F2 = 2...). In all but name, slot 0 is the 10th slot (ApiHawk/Lua complicates this).
In TAStudio, the branches are numbered from 0, and the default hotkeys are from F10 (F10 = 0, F1 = 1...)—though trying to save branch n will fill branches 0..(n-1) first.
I propose we:

• Rename slot 0 to 10 in the UI, including reordering the hotkey binds and File > Save Slot, and savestate filenames
• Change the savestate APIs to accept either 0 or 10 for slot 10, then in a later release deprecate accepting 0
• Rename TAStudio branch 0 to 1, 1 to 2, etc.

[TizianoMattei]

Personally i use the save/load state/branch nr.0 to be exclusively assigned to controller keybinds (which leaves f1 to f10 the rest of states), whenever im testing something before, or even during the works of a TAS, depending on the situation

That said it wouldnt be that big of a problem if that ends up being changed

[Morilli]

Personally i use the save/load state/branch nr.0 to be exclusively assigned to controller keybinds (which leaves f1 to f10 the rest of states)

You mean F1-F9 for the remaining states, right? Considering that there are only 10 savestates hotkeyable. In that case just using the 10th savestate instead of the 0th should work for you, although that is perhaps a little less "separated" logically.

[TizianoMattei]

You mean F1-F9 for the remaining states, right? Considering that there are only 10 savestates hotkeyable. In that case just using the 10th savestate instead of the 0th should work for you, although that is perhaps a little less "separated" logically.

Yes, apologies, i meant that.
Yea that would work, just shared to give a perspective on how some of the userbase might have used the save/load state 0

[YoshiRulz]

Partially implemented my suggestions in e7fd93b and 965cbe6. Please test the latter.