Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewind should increment rerecords #3707

Open
RetroEdit opened this issue Jul 18, 2023 · 4 comments
Open

Rewind should increment rerecords #3707

RetroEdit opened this issue Jul 18, 2023 · 4 comments
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements

Comments

@RetroEdit
Copy link
Contributor

RetroEdit commented Jul 18, 2023

Rewind is sort of useful for quickly creating a TAS, but it doesn't increment rerecords when recording a movie. As a user, it would make sense for it to increment when the rewind button is released, but I'm not sure how difficult that is on the backend.

As a workaround, there might be a way to do this with a quick script using callbacks? But, I'm not currently sure whether the scripting API supports this. Done: see below.

On the other hand, maybe I need to just have TAStudio open, which might be another workaround for this issue.

@YoshiRulz YoshiRulz added Enhancement For feature requests or possible improvements App: EmuHawk Relating to EmuHawk frontend labels Jul 18, 2023
@RetroEdit
Copy link
Contributor Author

RetroEdit commented Jul 19, 2023

As a temporary workaround, here's a Lua script I cooked up that infers when rewind rerecords happen and differentiates them from standard savestate loading. At least in 2.9.1, it doesn't count rerecords in TAStudio (see below).

Update (28 July 2023): I added the Lua script to my own repo: https://github.com/RetroEdit/retro_tas/blob/main/rewind_rerecords.lua

Additional note (2023-09-14): I recently tested in TAStudio, but recording mode is really janky and unchecks the checkbox when you're rewinding. There might be a way to work around this in my code, but it's not a high priority because recording mode is unfortunately kinda unsafe anyway (#3500).

@tommai78101
Copy link
Contributor

Is this a duplicate of this issue? #480

@YoshiRulz
Copy link
Member

Let's keep this separate as the "feature" appears to have been added since.

@tommai78101
Copy link
Contributor

Okay, good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements
Projects
None yet
Development

No branches or pull requests

3 participants