rename permission OverrideSubmissionStatus to OverrideSubmissionConst…

…raints and use it to override the submission filesize limit when editing a submission to replace a movie file
TASVideos · Jun 6, 2024 · 3722746 · 3722746
1 parent 57f15a5
commit 3722746
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/TASVideos.Core/Services/QueueService.cs b/TASVideos.Core/Services/QueueService.cs
@@ -89,7 +89,7 @@ internal class QueueService(
 		}
 
 		var perms = userPermissions.ToList();
-		if (perms.Contains(PermissionTo.OverrideSubmissionStatus))
+		if (perms.Contains(PermissionTo.OverrideSubmissionConstraints))
 		{
 			return Enum.GetValues<SubmissionStatus>()
 				.Except([Published]) // Published status must only be set when being published

diff --git a/TASVideos.Data/Entity/PermissionTo.cs b/TASVideos.Data/Entity/PermissionTo.cs
@@ -107,8 +107,8 @@ public enum PermissionTo
 	ReplaceSubmissionMovieFile = 203,
 
 	[Group("Queue Maintenance")]
-	[Description("The ability to set a submission status regardless of condition (exception: published submissions)")]
-	OverrideSubmissionStatus = 204,
+	[Description("The ability to override filesize and other limits, as well as set the submission status regardless of condition (exception: published submissions)")]
+	OverrideSubmissionConstraints = 204,
 
 	[Group("Queue Maintenance")]
 	[Description("The ability to deprecate an existing movie parser. When deprecated, a movie will no longer be eligible for submission")]

diff --git a/TASVideos/Pages/Submissions/Edit.cshtml.cs b/TASVideos/Pages/Submissions/Edit.cshtml.cs
@@ -112,7 +112,7 @@ public async Task<IActionResult> OnPost()
 				ModelState.AddModelError(FileFieldName, "Not a valid .zip file");
 			}
 
-			if (!Submission.ReplaceMovieFile.LessThanMovieSizeLimit())
+			if (!User.Has(PermissionTo.OverrideSubmissionConstraints) && !Submission.ReplaceMovieFile.LessThanMovieSizeLimit())
 			{
 				ModelState.AddModelError(FileFieldName, ".zip is too big, are you sure this is a valid movie file?");
 			}

diff --git a/TASVideos/Pages/Submissions/View.cshtml b/TASVideos/Pages/Submissions/View.cshtml
@@ -12,7 +12,7 @@
 	bool canPublish = User.Has(PermissionTo.PublishMovies)
 		&& Model.Submission.Status == SubmissionStatus.PublicationUnderway
 		&& Model.Submission.IsCataloged
-		&& (Model.Submission.Publisher == User.Name() || User.Has(PermissionTo.OverrideSubmissionStatus));
+		&& (Model.Submission.Publisher == User.Name() || User.Has(PermissionTo.OverrideSubmissionConstraints));
 	string statusColor = StatusColor(Model.Submission.Status);
 
 	bool canClaimAsJudge = User.Has(PermissionTo.JudgeSubmissions)

diff --git a/tests/TASVideos.Core.Tests/Services/QueueServiceTests.cs b/tests/TASVideos.Core.Tests/Services/QueueServiceTests.cs
@@ -29,7 +29,7 @@ private static DateTime OldEnoughToBeJudged
 	private static readonly IEnumerable<PermissionTo> BasicUserPerms = [PermissionTo.SubmitMovies];
 	private static readonly IEnumerable<PermissionTo> JudgePerms = [PermissionTo.SubmitMovies, PermissionTo.JudgeSubmissions];
 	private static readonly IEnumerable<PermissionTo> PublisherPerms = [PermissionTo.SubmitMovies, PermissionTo.PublishMovies];
-	private static readonly IEnumerable<PermissionTo> Override = [PermissionTo.OverrideSubmissionStatus];
+	private static readonly IEnumerable<PermissionTo> Override = [PermissionTo.OverrideSubmissionConstraints];
 
 	public QueueServiceTests()
 	{