Redirect module

[Randomno]

#268

Technically it works but it's garbage. I couldn't even figure out how to get the base URL and redirect to the specified path rather than a whole website. That's the only change that would be necessary to be merged (because it'll change how the module is used), but the whole thing should be redone.

Current usage: [module:redirect|page=https://tasvideos.org/SandBox]
Desired usage: [module:redirect|page=SandBox]

[adelikat]

To get teh baseurl, add AppSettings to the constructor of your class, then it will be in the BaseUrl property of that class

[Randomno]

Works as intended now. Still very minimal implementation and could do with the other features mentioned in #268 (comment) in the future. 2 I can do, others I have no idea.

[Masterjun3]

How are infinite redirects prevented?

[Randomno]

By the browser from what I tested

[Masterjun3]

I know we would avoid putting in loops, so it'd be rare, but I don't know if I'm comfortable trusting all browser behaviors to properly catch stuff like that. The problem is that it'd be a massive resource drain if any one doesn't stop it.

Btw, the Preview button gives an error alert if you redirect to a page that doesn't exist. Which is probably fine, it's just interesting that the 404 that comes from the PageNotFound goes directly into the JS fetch Preview request, and so it thinks something didn't work.

[Randomno]

Valid concern and I don't know how to address it. Check the contents of the target page and refuse to redirect if it also contains a redirect? Add something to the target URL like ?redirected=yes and ignore the next redirect if the URL contains it?

[Masterjun3]

I personally don't think a module for redirection is a proper solution. For me the modules are part of the content of wiki pages, and should not control the behavior of the page itself.

Personally my idea for a redirection would be a new database table, containing every redirect. Then we could add something like a /Wiki/Redirects page where people with proper permissions can create, edit, and delete wiki redirects. That's where we can then put in logic to prevent loops, and put in automation to create proper redirects when pages are moved.

[Randomno]

Fixed repeated redirects.

As for the implementation, I'm not a big fan of it for the same reason you gave. I'm basing it on the MediaWiki syntax of

#REDIRECT [[Page]]

This issue has been around for a long time now and it's holding back wiki reorganisation.

[Randomno]

Thoughts?

[adelikat]

Closing because this has not seen any progress in awhile, and may not be the direction we want to go to handle redirects