Skip to content

Commit

Permalink
#534 - Removed obsolete config on old code coverage badge generation (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
thehenrytsai committed Nov 1, 2023
1 parent 9e93526 commit 97bb384
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/integrity-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ jobs:
- run: npm run build
# runs linter. Job will fail if there are any warnings or errors
- run: npm run lint
# runs tests in node environment without attempting to generate code coverage badges
- run: npm run test:node:ci
# runs tests in node environment
- run: npm run test:node

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
- run: npm run license-check
# builds all bundles
- run: npm run build
# runs tests in node environment without attempting to generate code coverage badges
- run: npm run test:node:ci
# runs tests in node environment
- run: npm run test:node
# Note - this is not required but it gives a clean failure prior to attempting a release if the GH workflow runner is not authenticated with npm.js
- run: npm whoami
env:
Expand Down
2 changes: 0 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,5 +91,3 @@ Our preferred code style has been codified into `eslint` rules. Feel free to tak
| `npm run clean` | deletes `dist` dir |
| `npm run lint` | runs linter and displays all problems |
| `npm run lint:fix` | runs linter and attempts to auto-fix all problems |
| `npm run make-coverage-badges` | creates code coverage badges in `README.md` based on the code coverage result data generated by running tests |
| `npm run make-coverage-badges:ci` | creates code coverage badges and compare them against existing ones in `README.md`, errors out if they differ |
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<!-- @format -->
# Decentralized Web Node (DWN) SDK <!-- omit in toc -->

Code Coverage
[![codecov](https://codecov.io/github/TBD54566975/dwn-sdk-js/graphs/badge.svg)](https://codecov.io/github/TBD54566975/dwn-sdk-js)

- [Introduction](#introduction)
Expand Down
7 changes: 2 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,10 @@
"compile-validators": "node ./build/compile-validators.js",
"lint": "eslint . --ext .ts --max-warnings 0",
"lint:fix": "eslint . --ext .ts --fix",
"make-coverage-badges": "istanbul-badges-readme",
"make-coverage-badges:ci": "npm run make-coverage-badges -- --ci",
"test:node": "npm run compile-validators && tsc && c8 mocha \"dist/esm/tests/**/*.spec.js\" && npm run make-coverage-badges",
"test:node:ci": "npm run compile-validators && tsc && c8 mocha \"dist/esm/tests/**/*.spec.js\"",
"test:node": "npm run compile-validators && tsc && c8 mocha \"dist/esm/tests/**/*.spec.js\"",
"test:browser": "npm run compile-validators && cross-env karma start karma.conf.cjs",
"test:browser-debug": "npm run compile-validators && cross-env karma start karma.conf.debug.cjs",
"license-check": "license-report --only=prod > license-report.json && node ./build/license-check.cjs",
"publish:unstable": "./build/publish-unstable.sh"
}
}
}

0 comments on commit 97bb384

Please sign in to comment.