-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added prune
protocol action + ProtocolAuthorization
refactoring
#735
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
=======================================
Coverage 98.52% 98.53%
=======================================
Files 71 71
Lines 10563 10628 +65
Branches 1539 1550 +11
=======================================
+ Hits 10407 10472 +65
Misses 150 150
Partials 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got through most of it and it looks good!
Just a couple of NITS wrt naming/comments, but code logic looks solid.
Want to have another look at authorizeAgainstAllowedActions
to make sure I understood it correctly and also review the tests before I stamp, but looks good so far!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
prune
protocol action.constructRecordChain()
authorizeAgainstAllowedActions()
to make it more easily understood.