allow init in resources, add devtools and update all tests #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirahsapong
requested review from
jiyoontbd,
angiejones and
nitro-neal
as code owners
jiyoontbd
reviewed
Mar 29, 2024
kirahsapong
force-pushed
the
feat/add-devtools
branch
from
e05310f
to
b52a8c3
Compare
jiyoontbd
reviewed
Mar 29, 2024
| from: String, | ||
| to: String, | ||
| exchangeID: String = "exchange_123", | ||
| data: OrderStatusData? = nil, |
There was a problem hiding this comment.
Suggested change
| data: OrderStatusData? = nil, | |
| data: CloseData? = nil, |
jiyoontbd
reviewed
Mar 29, 2024
jiyoontbd
reviewed
Mar 29, 2024
| /// - Parameters: | ||
| /// - did: The Bearer DID with which to sign the resource | ||
| /// - keyAlias: An optional key alias to use instead of the default provided by the Bearer DID | ||
| public mutating func sign(did: BearerDID, keyAlias: String? = nil) throws { |
There was a problem hiding this comment.
could you explain to me what mutating keyword does here?
There was a problem hiding this comment.
it means sign is allowed to modify signature (or whatever other properties) of the struct
jiyoontbd
reviewed
Mar 29, 2024
jiyoontbd
approved these changes
Mar 29, 2024
|
cc: @acekyd @blackgirlbytes @EbonyLouis @angiejones @chris-tbd changes are in to introduce DevTools to swift 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #67
adds devtools helper methods, allows init on resources, and updates all tests