Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI Security, SAST and OSSF checks #19

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Add CI Security, SAST and OSSF checks #19

merged 9 commits into from
Feb 22, 2024

Conversation

leordev
Copy link
Member

@leordev leordev commented Feb 21, 2024

You don't need to be blocked by reported issues from our CI tools for now. But it's a good thermometer to see if we are stumbling in vulns and license issues to remediate them when needed.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@amika-sq
Copy link
Contributor

Looks like CodeQL is using an outdated Swift tools version

error: 'web5-swift': package 'web5-swift' is using Swift tools version 5.9.0 but the installed version is 5.7.1

Curious if there's a path to upgrade this. I could lower the required Swift version, but it would require some code changes. Happy to do it though if that's the only path forward.

@leordev
Copy link
Member Author

leordev commented Feb 22, 2024

Looks like CodeQL is using an outdated Swift tools version

error: 'web5-swift': package 'web5-swift' is using Swift tools version 5.9.0 but the installed version is 5.7.1

Curious if there's a path to upgrade this. I could lower the required Swift version, but it would require some code changes. Happy to do it though if that's the only path forward.

Thanks @amika-sq ! Let me explore first if theres an upgrade path for CodeQL!

@leordev leordev merged commit 915f12e into main Feb 22, 2024
3 checks passed
@leordev leordev deleted the leordev/ci-checks branch February 22, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants