Discovery Documentation; Additional Variables and Tweaks #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional information about the device model and such. This is all primarily cosmetic, but it might aid with support requests if a user can see their device info in a nice GUI.
This way it is only processed once, seems more streamlined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds a bunch of documentation for Discovery, including the user facing documentation.
I also added a few more variables for templating and tweaked some of them to improve their appearance.
The default
device_info_templatehas been improved to provide nice fall backs for decreasing knowledge about a device.I also streamlined some of the code around initialization.
Additional information
Checklist