-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVP Offline Game #10
Merged
Merged
MVP Offline Game #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings is a Singleton that currently only has volume which is a float to work well with the Sound Class. SettingScreen is empty but was still added to so that it isn't forgotten.
…and treewithpowerups. logic on how powerup is obtained to be implemented more in the controller side
… set position and chopping animation yet
notify had to be changed to endNotification so that it wouldn't clash with 'notify()' in 'java.lang.Object' going forward
updated to my latest code
updayed
updaed
updated
updated
All methods should start with a verb
The Gvm is needed for he GameController
# Conflicts: # core/src/no/ntnu/game/Models/Settings.java
To be used for changing the value of the sound. Should maybe be changed to be created with abstractfactory
Seems like only the Knob gets to decide how tall the slider can be
This was done so that SettingsView actually has an effect on the settings.
The tree shouldn't be drawn continuously
Views constructors only known when the render method is called
It is unclear how the internal logic should work together with the tree
This is to show off that is works as intended, though the buttons are not involved in the current solution.
# Conflicts: # core/src/no/ntnu/game/Views/SettingsScreen.java
Han branch
Game room selection deen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial progress. Game with sprites, animations, music, game effects, views and buttons