Objectify v6 compatibility testing #11016
Assignees
Labels
a-Storage
Database schema, Datastore-related technologies/quirks
a-Testing
Testing-related traits such as efficiency, robustness, coverage
committers only
Difficult; better left for committers or more senior developers
Projects
Comments
Derek-Hardy
added
committers only
|
|
Using Testing Approach 2: Backward:
Forward:
|
Derek-Hardy
changed the title
|
Approach 2: (backward - test on v5 data) env: Error: UPDATE:
|
|
Both errors seem to suggest that the data in the datastore might be in a format incompatible with the intended pojo field. I think it might be because currently we don't have any logic implemented to translate |
|
Environment: The error is resolved locally, after deleting the On google cloud console, I can see that Conclusion:
|
|
Backward compatibility test env: Backend exceptions: Failed tests: (28) Relevant code: // GetStudentAction.java
private static final String UNAUTHORIZED_ACCESS = "You are not allowed to view this resource!";
@Override
void checkSpecificAccessControl() {
String courseId = getNonNullRequestParamValue(Const.ParamsNames.COURSE_ID);
CourseAttributes course = logic.getCourse(courseId);
StudentAttributes student;
String studentEmail = getRequestParamValue(Const.ParamsNames.STUDENT_EMAIL);
String regKey = getRequestParamValue(Const.ParamsNames.REGKEY);
if (studentEmail != null) {
student = logic.getStudentForEmail(courseId, studentEmail);
if (student == null || userInfo == null || !userInfo.isInstructor) {
throw new UnauthorizedAccessException(UNAUTHORIZED_ACCESS);
}
InstructorAttributes instructor = logic.getInstructorForGoogleId(courseId, userInfo.id);
gateKeeper.verifyAccessible(instructor, logic.getCourse(courseId), student.section,
Const.InstructorPermissions.CAN_VIEW_STUDENT_IN_SECTIONS);
} else if (regKey != null) {
getUnregisteredStudent().orElseThrow(() -> new UnauthorizedAccessException(UNAUTHORIZED_ACCESS));
} else {
if (userInfo == null || !userInfo.isStudent) {
throw new UnauthorizedAccessException(UNAUTHORIZED_ACCESS);
}
student = logic.getStudentForGoogleId(courseId, userInfo.id);
gateKeeper.verifyAccessible(student, course);
}
}// GetCourseAction.java
@Override
void checkSpecificAccessControl() {
String entityType = getNonNullRequestParamValue(Const.ParamsNames.ENTITY_TYPE);
if (!((entityType.equals(Const.EntityType.STUDENT) && userInfo.isStudent)
|| (entityType.equals(Const.EntityType.INSTRUCTOR) && userInfo.isInstructor))) {
throw new UnauthorizedAccessException("Current account cannot access to courses of request entity type");
}
}// GateKeeper.java
public void verifyAccessible(InstructorAttributes instructor, CourseAttributes course) {
verifyNotNull(instructor, "instructor");
verifyNotNull(instructor.courseId, "instructor's course ID");
verifyNotNull(course, "course");
verifyNotNull(course.getId(), "course ID");
if (!instructor.courseId.equals(course.getId())) {
throw new UnauthorizedAccessException("Course [" + course.getId() + "] is not accessible to instructor ["
+ instructor.email + "]");
}
} |
|
Work is done |
wkurniawan07
moved this from Done in feature branch
to Shipped to master branch
in GAE Runtime Upgrade
wkurniawan07
removed
the
a-DevHelp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment:
releasebranchobjectify-v6-migrationbranchTesting approach 1: connect dev server to the staging server datastore
build.propertiesthe attributeapp.production.gcs.bucketname=tm-obj-v6-test.appspot.comcontextInitializedinOfyHelperas below:setupLocalDatastoreHelperandtearDownLocalDatastoreHelperinBaseE2ETestCaseclassTesting approach 2: export data from staging data buckets and import into emulator
gsutil -m cp -r "gs://v6_migration_db/2021-03-06T13:53:55_30312/" <dst_url>gcloud beta emulators datastore start --host-port=localhost:8484 --consistency=1.0input_urlpath.The text was updated successfully, but these errors were encountered: