Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LnP test framework to parse startup info #11083

Open
moziliar opened this issue Apr 5, 2021 · 1 comment
Open

Refactor LnP test framework to parse startup info #11083

moziliar opened this issue Apr 5, 2021 · 1 comment
Labels
a-Testing Testing-related traits such as efficiency, robustness, coverage c.Task Other non-user-facing works, e.g. refactoring, adding tests help wanted Moderate difficulty, small localized change; suitable for novice contributors

Comments

@moziliar
Copy link
Contributor

moziliar commented Apr 5, 2021

Referencing #11027

In file src/lnp/resources/test.template.properties, test server host is hardcoded. We aim to remove it and use the existing library to get such information, freeing the developer/testers from changing this config unnecessarily.
@moziliar moziliar added a-Testing Testing-related traits such as efficiency, robustness, coverage c.Task Other non-user-facing works, e.g. refactoring, adding tests help wanted Moderate difficulty, small localized change; suitable for novice contributors t-Java labels Apr 5, 2021
@anii1827
Copy link

anii1827 commented Dec 23, 2023 •
edited

Before starting work on this,
just need to clarify the requirements as per Reference PR #11027. The properties related to 'test.app.domain=localhost' should be removed, and instead, the code should be modified to parse host information from 'test.app.url=http://localhost:8080' available in test.properties file.

@moziliar is this information above correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-Testing Testing-related traits such as efficiency, robustness, coverage c.Task Other non-user-facing works, e.g. refactoring, adding tests help wanted Moderate difficulty, small localized change; suitable for novice contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wkurniawan07 @moziliar @anii1827