Users with deadline extensions may not be able to submit feedback responses in V9

[jayasting98]

The V9 version of verifySessionOpenExceptForModeration checks if the session is open, but it may not be checking if the session is open given a deadline.

teammates/src/main/java/teammates/ui/webapi/BasicFeedbackSubmissionAction.java

Lines 313 to 319 in 5b3a96f

	void verifySessionOpenExceptForModeration(FeedbackSession feedbackSession) throws UnauthorizedAccessException {
	String moderatedPerson = getRequestParamValue(Const.ParamsNames.FEEDBACK_SESSION_MODERATED_PERSON);
	if (StringHelper.isEmpty(moderatedPerson) && !(feedbackSession.isOpened() || feedbackSession.isInGracePeriod())) {
	throw new UnauthorizedAccessException("The feedback session is not available for submission", true);
	}
	}

Note that the code is similar to the pre-V9 version, but the difference is that FeedbackSessionAttributes::isOpened checks the deadline extension, while teammates.storage.sqlentity.FeedbackSession::isOpened does not check the deadline extension.

teammates/src/main/java/teammates/common/datatransfer/attributes/FeedbackSessionAttributes.java

Lines 330 to 333 in 5b3a96f

	public boolean isOpened() {
	Instant now = Instant.now();
	return (now.isAfter(startTime) || now.equals(startTime)) && now.isBefore(getDeadline());
	}

teammates/src/main/java/teammates/storage/sqlentity/FeedbackSession.java

Lines 466 to 469 in 5b3a96f

	public boolean isOpened() {
	Instant now = Instant.now();
	return (now.isAfter(startTime) || now.equals(startTime)) && now.isBefore(endTime);
	}

(The bug was spotted in the code, not in production, so the following does not apply.)

- Environment:

Steps to reproduce

Expected behaviour

Actual behaviour

Additional info

[jayasting98]

To add, any action that relies on verifySessionOpenExceptForModeration where deadline extensions apply may also be affected, such as (Create|Update|Delete)FeedbackResponseCommentAction.