instructorCourseInstructorAdd: doesn't create an Account for instructor

[damithc]

From dam...@gmail.com on November 21, 2013 08:53:34

When adding an instructor, both Instructor and Account objects should be created. If Account already exists, should be upgraded to instructor status if necessary.
Please check if this is the case. If not, update code and test cases.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1294

[damithc]

From OTS.Nexus on November 20, 2013 22:21:00

Status: Started

[damithc]

From OTS.Nexus on November 20, 2013 23:03:39

https://codereview.appspot.com/30210043/

Status: ReadyForReview

[damithc]

From dam...@gmail.com on November 20, 2013 23:41:04

Works for these cases?
(1)the account already exists and already an instructor
(2)the account already exists but only as student

These should be unit tested at logic.createInstructorAccount level. See if they are.

[damithc]

From OTS.Nexus on November 20, 2013 23:56:02

Yes, it works. But there is no unit testing done for the AccountLogic.createInstructorAccount() method yet. So I have to created them too?

[damithc]

From OTS.Nexus on November 21, 2013 02:47:20

Unit tests added: https://codereview.appspot.com/30210043/#ps20001

[damithc]

From dam...@gmail.com on November 21, 2013 03:14:46

This issue was updated by revision 641187d0234a .

[damithc]

From dam...@gmail.com on November 21, 2013 03:16:29

I merged this before unit tests were added. Add them afresh as a new issue. No hurry.
I also fixed a test that broke (You removed a method but didn't remove the unit test for that method)

Status: Deployed

[damithc]

From dam...@gmail.com on November 21, 2013 20:54:45

Labels: Milestone-V4.74

[damithc]

From dam...@gmail.com on February 26, 2014 01:56:50

This issue was updated by revision 641187d0234a .

[damithc]

[Change Log]
status: null ~> status.closed