Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Request: How JS Minification Works #8684

Closed
nashmia-riaz opened this issue Mar 19, 2018 · 2 comments
Closed

Help Request: How JS Minification Works #8684

nashmia-riaz opened this issue Mar 19, 2018 · 2 comments
Labels
a-DevHelp Help request from contributors; this label is not used anymore c.Message A means of communication with the core team; this label is not used anymore

Comments

@nashmia-riaz
Copy link
Contributor

Hello, prestigious dev team of Teammates!

I am a student from Pakistan, currently looking forward to applying for GSoC 2018.

I am trying to fix an issue and I think I understand most of the code flow. However, I am having trouble figuring out how the js in dev/js/main ends up getting minified and ultimately used in the webapp/js.

Could someone please explain this to me? I did refer to the 'Documentation for Developers' but couldn't find anything related to this. Please bear with me since I am new to JSP & JSTL.

@crphang
Copy link
Contributor

crphang commented Mar 19, 2018

The Javascript files are minified when you run npm run build. Take a look at https://github.com/TEAMMATES/teammates/blob/master/docs/development.md#building-javascript-files which describes that.

If you really want to know how it is done, you can take a look at the webpack configuration in webpack-main.config.js file. From there you can read more in Webpack documentation and Webpack's UglifyJsPlugin if you are interested to know about how it is done.

@damithc damithc added c.Message A means of communication with the core team; this label is not used anymore a-DevHelp Help request from contributors; this label is not used anymore labels Mar 19, 2018
@nashmia-riaz
Copy link
Contributor Author

@crphang Thank you so much. This is very helpful 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-DevHelp Help request from contributors; this label is not used anymore c.Message A means of communication with the core team; this label is not used anymore
Projects
None yet
Development

No branches or pull requests

3 participants