Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set IP in configuration #28

Closed
wants to merge 1 commit into from
Closed

Conversation

ernst77
Copy link

@ernst77 ernst77 commented Jan 4, 2022

I would suggest to allow users to set IP in configuration instead of trying to fetch with a command (which does not work and always will get internal docker ip).

@felipecrs
Copy link
Collaborator

It's meant to get the internal docker ip, what's wrong with that?

@ernst77
Copy link
Author

ernst77 commented Jan 5, 2022

It's meant to get the internal docker ip, what's wrong with that?

Sorry, but I don't understand why?
What is the point limiting connections only to it's own internal container IP (172.17. x.x), while https://github.com/TECH7Fox/Asterisk-integration is trying to connect with HA IP in LAN scope (192.168.x.x).
image

Or I should use different IP for integration? (IF it's using addon-on container ip, integration should get it automatically, as users wont be able to get containers IP)

@felipecrs
Copy link
Collaborator

Did you check the link I provided? It's working for me this way.

@felipecrs
Copy link
Collaborator

I.e.: can you try to setup the integration with host as b35499aa-asterisk and check if you still have issues making it connect? We can enhance documentation later.

@ernst77
Copy link
Author

ernst77 commented Jan 5, 2022

My bad, missed this config

@ernst77 ernst77 closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants