Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused, unwanted, and orphaned files in Test #216

Closed
martindholmes opened this issue Jan 6, 2017 · 7 comments
Closed

Unused, unwanted, and orphaned files in Test #216

martindholmes opened this issue Jan 6, 2017 · 7 comments
Assignees

Comments

@martindholmes
Copy link
Contributor

I'm using this ticket to track files which are in the Test directory but don't appear to have any purpose. Today I have:

test.cocoa: this seems to be a truncated version of cocoatest.txt, consisting of only 109 lines. It is not referenced from anywhere I can find. The git log has only one entry:

git log test.cocoa
commit 34a4ff51c8617d194b7af024e613be5944cccefb
Author: Sebastian Rahtz <sebastian.rahtz@gmail.com>
Date:   Sat Sep 20 12:20:05 2014 +0100

    discard  $Id$ in comments; Git doesn't expand them

which suggests it was added by accident.

ex1.xml: this looks like a MS description file created by Elena P in 2009, edited by Magdalena in 2014 and added in this commit:

Author: Magdalena Turska <magdalena.turska@it.ox.ac.uk>
Date:   Wed May 21 17:37:52 2014 +0100

    markdown test files

I've asked Magdalena about it. It's also not referenced from anywhere. I'll add more as I find them. It'll be helpful to get the clutter out of this directory, which is complicated enough already.

@martindholmes martindholmes self-assigned this Jan 6, 2017
@martindholmes
Copy link
Contributor Author

martindholmes commented Jan 6, 2017

floating-text-notes-renum-b.xml: No idea what this is, since it's mostly in Greek, but it found its way into the repo in 2013:

commit cb76cc32ea3ddd607e3bd1333a5c1121605ed4ff
Author: Sebastian Rahtz <sebastian.rahtz@gmail.com>
Date:   Sat Aug 31 21:04:34 2013 +0100

    process `<salute>` in standard way, so that @rend is noticed

It doesn't contain any <salute> elements, and doesn't seem to be referenced anywhere, so it looks like another orphan.

@martindholmes
Copy link
Contributor Author

formatexamples.xsl: This has a hard-coded import of a Stylesheet (verbatim.xsl) in /usr/share, and seems to be doing nothing but calling that stylesheet and overriding a couple of parameters. It doesn't seem to be referenced anywhere. It was first added in the 2013 commit referenced above, and subsequently changed in one subsequent commit. It looks like it was once used, but is no longer.

@martindholmes
Copy link
Contributor Author

martindholmes commented Jan 6, 2017

poem.xsl: This was added in 2014:

commit 3ecfad263a2f90563aa9b9456a4b48454e89ac34
Author: Sebastian Rahtz <Sebastian.Rahtz@it.ox.ac.uk>
Date:   Tue Sep 9 15:17:07 2014 +0100

    fun with decorating trees

It's not referenced by anything that I can find; the only change to it is a couple of months later when the phrase "all rights reserved" was removed from its comment. It appears to do highlighting of hi elements; it shows evidence in the comments of having originally been called processpb.xsl.

@martindholmes
Copy link
Contributor Author

test-tree.xml and test-tree-mini.xml: These are invalid TEI files (firstly because they have @type on <teiHeader>, and secondly because they have <forest> elements appearing as direct children of <p>). They are not referenced or used anywhere now, but were used extensively a few years ago; I suspect that they were test files used in the development of the forest/eTree/eLeaf processing code that now resides in Stylesheets/html/html_nets.xsl. That code still partly works -- it generates a single tree from the first <forest> element in the file, but not from the others. It depends on a Google API at https://www.google.com/jsapi, and given the changeable nature of Google services, it would probably be a good idea to add this back into the tests somehow, although it's not clear to me how the test process could actually check whether the code still works. It's not clear to me whether it's only supposed to handle the first tree in the file, or whether it's failing to process the others correctly. I'll make the files valid and leave them, but if we care about eTree processing we should check into this.

@martindholmes
Copy link
Contributor Author

test.cocoa and ex1.xml removed in commit 171f74f..f8116e6 and preceding; if no problems result, I'll keep going.

@martindholmes
Copy link
Contributor Author

Removed floating-text-notes-renum-b.xml in commit 6faccdf.

@martindholmes
Copy link
Contributor Author

Closing this because I'm no longer working on Test, and the original issues are fixed.

@martinascholger martinascholger added this to the Release 7.49.0 milestone Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants