Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some incorrect relative paths to CSSs in the EPub transformation #312

Closed
AlexJitianu opened this issue Feb 21, 2018 · 3 comments
Closed
Assignees

Comments

@AlexJitianu
Copy link

Hi,

I'm currently updating the TEI version bundled inside Oxygen XML Editor. While running our tests we discovered some bad paths inside xml\tei\stylesheet\epub\tei-to-epub.xsl
<xsl:param name="cssFile">../css/tei.css</xsl:param> <xsl:param name="cssODDFile">../css/odd.css</xsl:param> <xsl:param name="cssPrintFile">../css/epub-print.css</xsl:param>
These CSSs are not inside a "css" folder but exists directly in the "stylesheet" folder. When transforming, you get errors like:
Fatal error during transformation using D:\QA\oxygen\frameworks\tei\xml\tei\stylesheet\profiles\default\epub\to.xsl: Failed to read input file; SystemID: file:/D:/QA/oxygen/frameworks/tei/xml/tei/stylesheet/epub/tei-to-epub.xsl; Line#: 171; Column#: 23

Please let me know if there are other details that I can offer.

Best regards,
Alex

@peterstadler
Copy link
Member

Hmm, I 'fixed' some path issues recently at d25fe11 which seems to cause these troubles. So, how is this supposed to work?
There is a css folder within the Stylesheets' root directory. This one I tried to address with the aforementioned changes to the files epub/tei-to-epub.xsl and epub3/tei-to-epub3.xsl. (Which works for me, btw. Both when calling profiles/default/epub/to.xsl and epub/tei-to-epub.xsl)

I'm puzzled right now …

@peterstadler peterstadler self-assigned this Feb 23, 2018
@AlexJitianu
Copy link
Author

Hi,

I think I understand what's happening. There is indeed a css folder insdie the Stylesheets' root directory but it doesn't get included inside the release:
https://github.com/TEIC/Stylesheets/releases/download/v7.44.0/tei-xsl-7.44.0.zip

@peterstadler
Copy link
Member

I see …
In

cp names.xml catalog.xml VERSION css/*.css i18n.xml release/xslcommon/xml/tei/stylesheet
the css files (from the css subfolder) get copied to the root of the distributable archive. Hence, we end up with different relative paths for these files when working with a checked out repository or with the released archive.
I wonder what the rationale behind this was/is?

Overall, that seems to be a whole can of worms here, because e.g. tei_msdescription.css seems not to be included anywhere; teislides.css on the other hand is available twice, once at /slides/teislides.css and once more at /css/teislides.css with several differences between those files. So, what's the 'right' place for these files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants