Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docx problem with <hi> over special chars (with fix!) #389

Closed
TomazErjavec opened this issue Aug 30, 2019 · 1 comment
Closed

docx problem with <hi> over special chars (with fix!) #389

TomazErjavec opened this issue Aug 30, 2019 · 1 comment
Assignees
@peterstadler
Milestone
Release 7.49.0

Comments

@TomazErjavec
Copy link
Contributor

For special characters that are in DOCX files written with <w:sym> the conversion from DOCX ignores their styling, i.e. does not wrap them in <hi> with appropriate @rend.
For an example see http://nl.ijs.si/tei/convert/log/rP7WlZiWM1/Pravopisna_pravila-vzorec_2019-08-28/tei.xml where the symbol ⇒ should have been converted to <hi rend="color(0070C0)">⇒</hI> (ditto for ∧) but isn't.

The culprit is line 358 in Stylesheets/docx/from/textruns.xsl, which reads:

 <xsl:when test="normalize-space(.)=''">

It should be

 <xsl:when test="normalize-space(.)='' and not(w:sym)">
@peterstadler peterstadler self-assigned this Sep 1, 2019
peterstadler added a commit that referenced this issue Sep 1, 2019
@peterstadler @TomazErjavec
apply fix provided by @TomazErjavec #389
fcc0383 
Co-Authored-By: Tomaž Erjavec <tomazerjavec@users.noreply.github.com>
peterstadler added a commit that referenced this issue Sep 1, 2019
@peterstadler
add test for issue #389
444f9f9
tuurma pushed a commit that referenced this issue Sep 15, 2019
@peterstadler @tuurma
colored symbols in docx2tei (#390)
d815bd3 
* apply fix provided by @TomazErjavec #389

Co-Authored-By: Tomaž Erjavec <tomazerjavec@users.noreply.github.com>

* trying to fix indentation

* add test for issue #389
@peterstadler peterstadler added this to the Release 7.49.0 milestone Sep 16, 2019
@peterstadler
Copy link
Member

fixed in #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterstadler peterstadler

Labels
None yet
Projects
None yet
Milestone
Release 7.49.0
Development

No branches or pull requests
2 participants
@peterstadler @TomazErjavec