Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted word "Attributes" appears in HTML output tagdocs #515

Closed
martindholmes opened this issue Jul 2, 2021 · 5 comments
Closed

Unwanted word "Attributes" appears in HTML output tagdocs #515

martindholmes opened this issue Jul 2, 2021 · 5 comments
Assignees
Labels
conversion: html conversion: odd priority: low Not urgent; can be dealt with when someone has free time or is looking for a project. resp: StylesheetsGroup Issue is suitable for the group-learning approach taken in the Stylesheets Coop Working Group. status: confirmed E.g., the bug reported has been confirmed by an independant observer. type: bug A bug report.

Comments

@martindholmes
Copy link
Contributor

@sydb and I, looking at issue #506, discovered that in HTML output documentation from user ODD files (not the Guidelines), the word "Attributes" appears in the tagdocs tables for elements and attribute classes, not only in the left column as a label, but also in the right column next to it, before the list of attributes. This results from two calls, on lines 2678 and 2696 of common_tagdocs.xsl. The first call mostly happens in elementSpecs, and the second mostly in attribute classes, although that's not 100% the case. If we could figure out what the $autoGlobal variable does, that would help; it seems to be 'false' by default, and that's causing these things to be output, so perhaps somewhere it should be set to 'true' for this specific output purpose.

@martindholmes martindholmes added type: bug A bug report. resp: StylesheetsGroup Issue is suitable for the group-learning approach taken in the Stylesheets Coop Working Group. conversion: html conversion: odd status: confirmed E.g., the bug reported has been confirmed by an independant observer. labels Jul 2, 2021
@martindholmes
Copy link
Contributor Author

A look at the history of the Exemplars in TEI releases suggests that this goes back well over a decade.

@HelenaSabel HelenaSabel self-assigned this Aug 20, 2021
@HelenaSabel HelenaSabel added the priority: low Not urgent; can be dealt with when someone has free time or is looking for a project. label Aug 20, 2021
@martindholmes
Copy link
Contributor Author

martindholmes commented Nov 22, 2021

martindholmes added a commit that referenced this issue Nov 25, 2021
#515: rewrote attribute listings output to suppress unwanted word.
@martindholmes
Copy link
Contributor Author

Working with @HelenaSabel, @npcole, @sydb, and @martinascholger on this in branch issue-515-caption.

@npcole
Copy link

npcole commented Nov 25, 2021

Do it

HelenaSabel added a commit that referenced this issue Nov 25, 2021
Issue #515: “Attribute” repeated in tagdoc
@sydb
Copy link
Member

sydb commented Nov 25, 2021

@martindholmes, @HelenaSabel, @npcole, @martinascholger, and I just met and fixed this puppy. (We hope.)

@sydb sydb closed this as completed Nov 25, 2021
@martinascholger martinascholger added this to the Release 7.53.0 milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conversion: html conversion: odd priority: low Not urgent; can be dealt with when someone has free time or is looking for a project. resp: StylesheetsGroup Issue is suitable for the group-learning approach taken in the Stylesheets Coop Working Group. status: confirmed E.g., the bug reported has been confirmed by an independant observer. type: bug A bug report.
Projects
None yet
Development

No branches or pull requests

5 participants