Merged
Conversation
sydb
approved these changes
Oct 22, 2022
Member
sydb
left a comment
sydb
left a comment
There was a problem hiding this comment.
I do not know why dozens of definitions of model classes generated as _alternation, _sequenceOptional, _sequenceOptionalRepeatable, and _sequenceRepeatable are occuring in the newly generated expected results, but not in the original expected results. (It can’t really be because of a change in the subset, can it? Maybe there is some code somewhere that says “if one is used generate all”?)
That said, I do not see it as a problem, just a mystery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR updates the p5subset.xml used for the Stylesheet tests and overwrites the expected results where necessary.