Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused test files should be removed #1942

Closed
martindholmes opened this issue Oct 18, 2019 · 4 comments
Closed

Unused test files should be removed #1942

martindholmes opened this issue Oct 18, 2019 · 4 comments
Assignees

Comments

@martindholmes
Copy link
Contributor

martindholmes commented Oct 18, 2019

@sydb and I, trying to figure out how tests work, believe that the following files in the Test directory are never used:

  • transcr1.xsl
  • transcr3.xsl
  • transcr4.xsl (and if this file goes, then surfaces.css can also go, because it's the only file that uses it)
  • svg2svg.xsl
  • study.svg
  • tei2kml.xsl
  • graves.xml (this is an invalid file, we think created by taking a P4 file and adding a P5 namespace)

Also:

  • schemas.xml (this is an emacs-specific file that links xml files to their schemas; where these links are still relevant, they should be placed in the source xml files as xml-model declarations.)

  • transcr2.xsl is used in an xml-stylesheet declaration, but we don't see how that could be part of a mechanical test.

  • All of the extns.* files relate to SGML and DTD entity features which we shouldn't be bothering to test at this point. We could remove these and the corresponding Makefile section.

These files should be deleted, or moved to a "Defunct" directory.

@tuurma tuurma self-assigned this Oct 23, 2019
@duncdrum
Copy link
Contributor

can't happen quickly enough

@sydb
Copy link
Member

sydb commented Dec 29, 2019

Given that this git thing is a version control system, I say we can just delete them quite quickly. If it turns out we need one back, we can get it back.

@martindholmes
Copy link
Contributor Author

Fair enough. You do have to know they existed in order to retrieve them, though. We sometimes move things to directories called Defunct or Obsolete instead.

@martinascholger martinascholger added this to the Guidelines 4.1.0 milestone Jun 14, 2020
@sydb sydb assigned sydb and unassigned tuurma Oct 24, 2020
sydb added a commit that referenced this issue Oct 25, 2020
sydb added a commit that referenced this issue Oct 25, 2020
sydb added a commit that referenced this issue Oct 25, 2020
sydb added a commit that referenced this issue Oct 25, 2020
sydb added a commit that referenced this issue Oct 25, 2020
@sydb
Copy link
Member

sydb commented Oct 25, 2020

Done, in 5 separate commits:

  1. phase 1, 8a72c39: remove the 8 or so obvious files, the 1st list in the OP
  2. phase 2a, 808cc03: remove schemas.xml
  3. phase 2b, c0d87c7: remove transcr2.xsl
  4. phase 2c, 0c30fdb: remove extns*
  5. phase 2d, 8556607: remove parts of Makefile that used the extns* files (I had done this for part of phase 2c, but failed to add Makefile, so it did not get committed. Sigh.)

@sydb sydb closed this as completed Oct 25, 2020
hcayless pushed a commit that referenced this issue Jun 26, 2022
hcayless pushed a commit that referenced this issue Jun 26, 2022
hcayless pushed a commit that referenced this issue Jun 26, 2022
hcayless pushed a commit that referenced this issue Jun 26, 2022
hcayless pushed a commit that referenced this issue Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants