-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile target names for PDF are confusing #2217
Comments
The idea of improving those targets sounds good to me. As always, naming issues are the hardest! |
Good point. I think step names How about just The |
Ok, so do we really need to keep the second step (on its own, without calling the first run first)? That might have some benefit for debugging, but in general you always need the first step before running the second. And since we are renaming things, dependent software (if any) will need to be updated anyway. |
Note: PR 2230 implements @peterstadler’s idea. |
aftermath of TEIC/TEI#2217
The Makefile has 3 targets for PDF:
Guidelines-pdf:
,pdf-complete:
, andpdf:
. When I inadvertently use the wrong one, you can chalk it up to my being a PDF-generation novice. But @martindholmes just made the same mistake, too, and he is well versed in this stuff. So I claim the names are misleading, and plan to change them:pdfonce
target in the antbuilder.xml file (after runningcheck.stamp
,p5.xml
, and checkingUtilities/guidelines-latex.xsl
) — rename to pdf-initpdfrest
target in the antbuilder.xml file (why doesn’t it runGuidelines-pdf:
first, anyway?) — rename to pdf-finishThe text was updated successfully, but these errors were encountered: