Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAR not available and Maven repositories not working #34

Closed
teoric opened this issue Oct 29, 2022 · 4 comments
Closed

WAR not available and Maven repositories not working #34

teoric opened this issue Oct 29, 2022 · 4 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@teoric
Copy link

teoric commented Oct 29, 2022

Currently, neither the nigthly link for the Docker image nor for the WAR work (Error 404). Moreover, with the provided settings.xml and a GitHub token, using maven results in

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project teigarage: Could not resolve dependencies for project pl.psnc.dl.ege.webapp:teigarage:war:1.0.0: Failed to collect dependencies at pl.psnc.dl.ege:ege-framework:jar:0.5.1

The releases page only contains source code for 1.0.0, and a war for 0.6.0.

Is TEIGarage 1.0.0 not yet ready for binary distribution or use by outsiders, or did I miss something?

anneferger added a commit that referenced this issue Oct 31, 2022
@anneferger
Copy link
Contributor

anneferger commented Oct 31, 2022

Hello, thank you for opening this issue. Yes, the nightly links were not updated in the Readme, but I did update them now. The docker file and war can be accessed without the nightly links though: The war is built using GitHub Actions and available from there (also for all older versions): https://github.com/TEIC/TEIGarage/actions and the Docker image is available at the GitHub Registry as well as on DockerHub.
I also added the war files to the releases as well.

The maven error with the GitHub settings file refers to https://github.com/TEIC/ege-framework/packages/1603900?version=0.5.1 which is available, I will have another look what may be the issue there.

@peterstadler peterstadler added bug Something isn't working question Further information is requested labels Oct 31, 2022
@anneferger
Copy link
Contributor

I tested the settings.xml on another machine and didn't find any errors when using a GitHub PAT with packages:read scope (https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-apache-maven-registry#installing-a-package). I'm happy to look at the output of mvn -X package if this error persists.

@teoric
Copy link
Author

teoric commented Nov 1, 2022

Thank you for the information, and for updating the Readme in a way that I now understand how to set authentication. As I had never used GitHub packages before, I did not get the repository right, but now the instructions are much, clearer. Thanks again!

Regarding the building process, it might also make sense to state which Java version is needed. For me, OpenJDK 11 worked, but 17 and 19 did not.

@anneferger
Copy link
Contributor

Thank you for the suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants