feat(gui): remove assumptions about admins methods #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
feat/no-contract-assumptions
branch
3 times, most recently
from
a3767af
to
fa897f5
Compare
|
chadoh
force-pushed
the
feat/no-contract-assumptions
branch
from
fa897f5
to
0256a07
Compare
This removes entanglement between what will soon become a general-purpose frontend and the admins behavior of the TenK contract. Instead, it only assumes that a specific comment format is followed in the contract. In the future these comments will be generated in the wit if an admins macro is present for the given contract method. Now `Change Methods` in the UI will be longer or shorter, depending on which methods the signed-in user is able to call.
chadoh
force-pushed
the
feat/no-contract-assumptions
branch
from
0256a07
to
90845c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes entanglement between what will soon become a
general-purpose frontend and the admins behavior of the TenK contract.
Instead, it only assumes that a specific comment format is followed in
the contract. In the future these comments will be generated in the wit
if an admins macro is present for the given contract method.
Now
Change Methodsin the UI will be longer or shorter, depending onwhich methods the signed-in user is able to call.